Change in python/osmo-python-tests[master]: osmo_ctrl.py: properly ignore out-of-order traps

[Pau Espin Pedrol]

Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11909 )

Change subject: osmo_ctrl.py: properly ignore out-of-order traps
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11909/3/scripts/osmo_ctrl.py
File scripts/osmo_ctrl.py:

https://gerrit.osmocom.org/#/c/11909/3/scripts/osmo_ctrl.py@44
PS3, Line 44:         while True:
I'd prefer having 1 less sck.recv call to care about. This code can be simplified now:

while True:
  ret = sck.recv(4096)
  ret = Ctrl().skip_traps(ret)
  if ret:
     (i, k, v) = Ctrl().parse(ret)
     break



-- 
To view, visit https://gerrit.osmocom.org/11909
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6de02c2f13a56f0381c97a9ab02c6c7a31cc32f
Gerrit-Change-Number: 11909
Gerrit-PatchSet: 3
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Nov 2018 18:18:55 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/f4218de8/attachment.htm>