Change in osmo-bts[master]: bts-trx: early return on POWERON success

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Nov 26 16:34:43 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11905 )

Change subject: bts-trx: early return on POWERON success
......................................................................

bts-trx: early return on POWERON success

Later on it's expected to add more rsp parsing, so let's return here and
not depend on generic return further down.

Change-Id: I8ddee46374ab329c47dc68e720e236f13d393f66
---
M src/osmo-bts-trx/trx_if.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c
index b048170..abe6846 100644
--- a/src/osmo-bts-trx/trx_if.c
+++ b/src/osmo-bts-trx/trx_if.c
@@ -450,6 +450,7 @@
 		if (rsp->status == 0) {
 			if (pinst->phy_link->state != PHY_LINK_CONNECTED)
 				phy_link_state_set(pinst->phy_link, PHY_LINK_CONNECTED);
+			return 0;
 		} else {
 			LOGP(DTRX, LOGL_NOTICE,
 			     "transceiver (%s) rejected POWERON command (%d), re-trying in a few seconds\n",

-- 
To view, visit https://gerrit.osmocom.org/11905
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ddee46374ab329c47dc68e720e236f13d393f66
Gerrit-Change-Number: 11905
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/aeb71466/attachment.htm>


More information about the gerrit-log mailing list