Change in python/osmo-python-tests[master]: ctrl: add optional TRAP-skipping parameter to split_combined()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 26 16:09:31 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 )

Change subject: ctrl: add optional TRAP-skipping parameter to split_combined()
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11929/1/osmopy/osmo_ipa.py
File osmopy/osmo_ipa.py:

https://gerrit.osmocom.org/#/c/11929/1/osmopy/osmo_ipa.py@119
PS1, Line 119:         remaining messages, first is the single IPA message with. Neither have headers stripped.
This line makes no sense: "with. Neither headers stripped" ?


https://gerrit.osmocom.org/#/c/11929/1/osmopy/osmo_ipa.py@124
PS1, Line 124:         (length, _, _, d) = self.del_header(data)
calling var "payload" instead of "d" would make it more easy to understand.



-- 
To view, visit https://gerrit.osmocom.org/11929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51ce207c19a1ca96c3e2af7d5efd64f79b02fbb4
Gerrit-Change-Number: 11929
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Mon, 26 Nov 2018 16:09:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/10a8e859/attachment.htm>


More information about the gerrit-log mailing list