Change in libosmocore[master]: ctrl: use #define for TRAP id

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Mon Nov 26 09:45:59 UTC 2018


Max has uploaded this change for review. ( https://gerrit.osmocom.org/11926


Change subject: ctrl: use #define for TRAP id
......................................................................

ctrl: use #define for TRAP id

We always use id = 0 when sending TRAP messages. Let's make this more
obvious by introducing appropriate define.

Change-Id: I33d7d4c6a1885a75a85d6f2f017430e0860b4126
---
M include/osmocom/ctrl/control_cmd.h
M src/ctrl/control_if.c
2 files changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/26/11926/1

diff --git a/include/osmocom/ctrl/control_cmd.h b/include/osmocom/ctrl/control_cmd.h
index 93055c7..276a7de 100644
--- a/include/osmocom/ctrl/control_cmd.h
+++ b/include/osmocom/ctrl/control_cmd.h
@@ -12,6 +12,7 @@
 #define CTRL_CMD_ERROR		-1
 #define CTRL_CMD_HANDLED	0
 #define CTRL_CMD_REPLY		1
+#define CTRL_CMD_TRAP_ID	"0"
 
 struct ctrl_handle;
 
diff --git a/src/ctrl/control_if.c b/src/ctrl/control_if.c
index ed18a2f..5ff4fd6 100644
--- a/src/ctrl/control_if.c
+++ b/src/ctrl/control_if.c
@@ -156,7 +156,7 @@
 	if (!cmd)
 		return -ENOMEM;
 
-	cmd->id = "0"; /* It's a TRAP! */
+	cmd->id = CTRL_CMD_TRAP_ID; /* It's a TRAP! */
 	cmd->variable = (char *) name;
 	cmd->reply = value;
 	r = ctrl_cmd_send_to_all(ctrl, cmd);

-- 
To view, visit https://gerrit.osmocom.org/11926
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33d7d4c6a1885a75a85d6f2f017430e0860b4126
Gerrit-Change-Number: 11926
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181126/18fa003c/attachment.htm>


More information about the gerrit-log mailing list