Change in osmo-msc[master]: libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error}

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Sun Nov 25 22:46:28 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11914 )

Change subject: libmsc/gsm_04_11.c: don't pass msgb to gsm411_rx_rp_{ack|error}
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11914/1/src/libmsc/gsm_04_11.c
File src/libmsc/gsm_04_11.c:

https://gerrit.osmocom.org/#/c/11914/1/src/libmsc/gsm_04_11.c@703
PS1, Line 703: static int gsm411_rx_rp_ack(struct gsm_trans *trans,
so msg parma was not being used at all? strange compiler didn't warn/error about it.



-- 
To view, visit https://gerrit.osmocom.org/11914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eb5c7c485ab7d109966431bd875fa74e00936d7
Gerrit-Change-Number: 11914
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 25 Nov 2018 22:46:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181125/89f11abc/attachment.htm>


More information about the gerrit-log mailing list