This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11847 )
Change subject: templates: bsc/nitb: Remove explicit no force-combined-si
......................................................................
templates: bsc/nitb: Remove explicit no force-combined-si
It's always been the default anyway, so no need to explicitly state it.
Furthermore, recently (osmobsc 167cb828665b91ed7d28007abd4a1862ebbb78c9)
force-combined-si was enabled by default for nanoBTS due to issues with
some MS not registering when it's not enabled, so let's osmo-bsc decide
were should it be enabled.
Related: OS#3063
Change-Id: I97b10406a4a0048c66a47aa7d32a113f0c0366d1
---
M selftest/template_test.ok
M src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl
M src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl
3 files changed, 0 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
Pau Espin Pedrol: Looks good to me, approved
diff --git a/selftest/template_test.ok b/selftest/template_test.ok
index f970bf6..88b77b0 100644
--- a/selftest/template_test.ok
+++ b/selftest/template_test.ok
@@ -77,7 +77,6 @@
gprs nsvc 0 local udp port 23020
gprs nsvc 0 remote udp port 23000
gprs nsvc 0 remote ip val_bts.sgsn_ip_addr_bts0
- no force-combined-si
trx 0
rf_locked 0
arfcn val_trx_arfcn_trx0
@@ -148,7 +147,6 @@
gprs nsvc 0 local udp port 23020
gprs nsvc 0 remote udp port 23000
gprs nsvc 0 remote ip val_bts.sgsn_ip_addr_bts1
- no force-combined-si
trx 0
rf_locked 0
arfcn val_trx_arfcn_trx0
diff --git a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl
index 4f39f79..53e683b 100644
--- a/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl
@@ -85,7 +85,6 @@
gprs nsvc 0 local udp port 23020
gprs nsvc 0 remote udp port 23000
gprs nsvc 0 remote ip ${bts.sgsn.ip_address.addr}
- no force-combined-si
% else:
gprs mode none
% endif
diff --git a/src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl
index 764ca94..ee7381f 100644
--- a/src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl
+++ b/src/osmo_gsm_tester/templates/osmo-nitb.cfg.tmpl
@@ -77,7 +77,6 @@
gprs nsvc 0 local udp port 23020
gprs nsvc 0 remote udp port 23000
gprs nsvc 0 remote ip ${bts.sgsn.ip_address.addr}
- no force-combined-si
% else:
gprs mode none
% endif
--
To view, visit https://gerrit.osmocom.org/11847
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I97b10406a4a0048c66a47aa7d32a113f0c0366d1
Gerrit-Change-Number: 11847
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181123/dcbfa27c/attachment.htm>