Change in osmo-hlr[master]: add database schema versioning to the HLR database

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 23 11:07:41 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11898 )

Change subject: add database schema versioning to the HLR database
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11898/1/sql/hlr.sql
File sql/hlr.sql:

https://gerrit.osmocom.org/#/c/11898/1/sql/hlr.sql@48
PS1, Line 48: 	-- last_lu_seen TIMESTAMP default NULL
> I understand where you are coming from. Having spent some time on this already, […]
I really fail to see your arguments related to what I am asking, maybe I expressed myself in a wrong way or there's something I'm not understanding myself.

I'm asking to leave everything exactly as it is in this patch, but modify this hlr.sql to be a representation of v1 table, that is add the new field in the subscriber database, and add an INSERT statement that adds version=1 to "meta" table.

This file is only used in case a new database needs to be created. In that case, we know it will always be latest supported version, so in that code path we don't need to go through upgrade procedure.

With this change I request, all other code paths work exactly the same.

I don't want requiring to run osmo-hlr process (and having to provide a related working config and setup with IP, port, etc.) to get a .db file that is up to date and which I can populate.



-- 
To view, visit https://gerrit.osmocom.org/11898
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b
Gerrit-Change-Number: 11898
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Nov 2018 11:07:41 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181123/3a327ba0/attachment.htm>


More information about the gerrit-log mailing list