This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11861 ) Change subject: replace bogus memcpy() call in ippool_newip() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11861/1/lib/ippool.c File lib/ippool.c: https://gerrit.osmocom.org/#/c/11861/1/lib/ippool.c@522 PS1, Line 522: OSMO_ASSERT(false); Don't do that. Better return like done in check in line 464. It could be that you requested an IPv6 addr for an IPv4 pool. In practice it doesn't matter much because we don't support static configs yet in osmo-ggsn afair, but anyway, let's avoid adding ASSERTs were we can simply return an error (IMHO is best practice a library should never call abort()). -- To view, visit https://gerrit.osmocom.org/11861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic21560f7519e776107485a8779702fb1279d065c Gerrit-Change-Number: 11861 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 21 Nov 2018 15:41:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181121/c6e63a57/attachment.htm>