This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/11848 ) Change subject: Revert "mobile: fix vty bind ip override" ...................................................................... Revert "mobile: fix vty bind ip override" This reverts commit c8de8cb1e126a18c0269571fba38310589dd9273 (Change-Id I32517567847fd5c54b1742f18bf409ff81e316fa by Max), because several problems were introduced, in particular: a) Help message of mobile application is broken: "The VTY IP to telnet to. (default (null))", "The VTY port number to telnet to. (default 127.0.0.1)". b) Default VTY bind addres != parsed from the config file. c) The (vty_ip == NULL) is resolved only when an external MNCC handler is used, otherwise NULL is passed to l23_app_init(). Change-Id: Ic63a4eb828ff32d3744886b4f5f6f5019c798620 --- M src/host/layer23/src/mobile/main.c 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified Max: Looks good to me, but someone else must approve Pau Espin Pedrol: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/main.c b/src/host/layer23/src/mobile/main.c index 297a534..115ac41 100644 --- a/src/host/layer23/src/mobile/main.c +++ b/src/host/layer23/src/mobile/main.c @@ -31,7 +31,6 @@ #include <osmocom/core/gsmtap.h> #include <osmocom/core/signal.h> #include <osmocom/core/application.h> -#include <osmocom/vty/vty.h> #include <arpa/inet.h> @@ -52,7 +51,7 @@ static char *gsmtap_ip = 0; static const char *custom_cfg_file = NULL; struct gsmtap_inst *gsmtap_inst = NULL; -static char *vty_ip = NULL; +static char *vty_ip = "127.0.0.1"; unsigned short vty_port = 4247; char *config_dir = NULL; int use_mncc_sock = 0; @@ -91,7 +90,7 @@ printf(" -u --vty-ip The VTY IP to telnet to. " "(default %s)\n", vty_ip); printf(" -v --vty-port The VTY port number to telnet to. " - "(default %s)\n", vty_get_bind_addr()); + "(default %u)\n", vty_port); printf(" -d --debug Change debug flags. default: %s\n", debug_default); printf(" -D --daemonize Run as daemon\n"); @@ -249,7 +248,7 @@ config_dir = dirname(config_dir); if (use_mncc_sock) - rc = l23_app_init(mncc_recv_socket, config_file, vty_ip ? vty_ip : vty_get_bind_addr(), vty_port); + rc = l23_app_init(mncc_recv_socket, config_file, vty_ip, vty_port); else rc = l23_app_init(NULL, config_file, vty_ip, vty_port); if (rc) -- To view, visit https://gerrit.osmocom.org/11848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic63a4eb828ff32d3744886b4f5f6f5019c798620 Gerrit-Change-Number: 11848 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181121/5ad2b16a/attachment.htm>