Change in osmo-gsm-manuals[master]: move OsmoMSC files to osmo-msc.git

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Nov 20 17:58:38 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11738 )

Change subject: move OsmoMSC files to osmo-msc.git
......................................................................


Patch Set 7: Code-Review-1

(4 comments)

https://gerrit.osmocom.org/#/c/11738/7//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11738/7//COMMIT_MSG@7
PS7, Line 7: move OsmoMSC files to osmo-msc.git
You are not moving them here, you are removing them from osmo-gsm-manuals.

I'd say: Remove OsmoMSC files (now avail in osmo-msc.git)


https://gerrit.osmocom.org/#/c/11738/7//COMMIT_MSG@9
PS7, Line 9: Add to osmo-msc.git with I2f9c27f81940b02414f0e618483bffade72e8cf7.
Is this Change-Id part of osmo-msc.git?
Then: 
"files were added in osmo-msc.git Change-Id I2f9c27f81940b02414f0e618483bffade72e8cf7."


https://gerrit.osmocom.org/#/c/11738/7//COMMIT_MSG@14
PS7, Line 14: Related: OS#3385
Depends: osmo-msc.git Change-Id I2f9c27f81940b02414f0e618483bffade72e8cf7


https://gerrit.osmocom.org/#/c/11738/7/Makefile.am
File Makefile.am:

https://gerrit.osmocom.org/#/c/11738/7/Makefile.am@8
PS7, Line 8: SUBDIRS = tests OsmoBSC OsmoBTS OsmoGGSN OsmoGSMTester OsmoHLR OsmoMGCP OsmoMGW OsmoNAT OsmoNITB OsmoPCU \
Would make sense to split this line into a multiline with \, since we'll be changing it a lot in follow-up patches.



-- 
To view, visit https://gerrit.osmocom.org/11738
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib234fe4f4ac36c27a4ad8a8d0050c1d6874232bc
Gerrit-Change-Number: 11738
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Nov 2018 17:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/f4c6f2ea/attachment.htm>


More information about the gerrit-log mailing list