Change in libosmo-abis[master]: osmo_ortp: Log domain and fix strings without endl char

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Tue Nov 20 16:47:52 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11744 )

Change subject: osmo_ortp: Log domain and fix strings without endl char
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11744/1/src/trau/osmo_ortp.c
File src/trau/osmo_ortp.c:

https://gerrit.osmocom.org/#/c/11744/1/src/trau/osmo_ortp.c@109
PS1, Line 109: 	int needs_endl;
> (curious, why not bool ... […]
Because it's actually used as an integer to calculate size needed to alloc.



-- 
To view, visit https://gerrit.osmocom.org/11744
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6df0df04cd6ba342753c84398274d04917ace40
Gerrit-Change-Number: 11744
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Nov 2018 16:47:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/0fd634f3/attachment.htm>


More information about the gerrit-log mailing list