This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11827 ) Change subject: LCLS: add GCR routines ...................................................................... Patch Set 5: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/11827/5/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/11827/5/src/gsm/gsm0808.c@416 PS5, Line 416: if (!g) Do we really need this kind of check? why would you expect somebdy to pass g=NULL? that looks wrong. https://gerrit.osmocom.org/#/c/11827/5/tests/gsm0808/gsm0808_test.c File tests/gsm0808/gsm0808_test.c: https://gerrit.osmocom.org/#/c/11827/5/tests/gsm0808/gsm0808_test.c@140 PS5, Line 140: memset(p.cr, 0, 5); sizeof(p.cr). Probably you even want memset(0) whole p since it comes from the stack. https://gerrit.osmocom.org/#/c/11827/5/tests/gsm0808/gsm0808_test.c@141 PS5, Line 141: memset(g.cr, 'F', 5); sizeof(g.cr) -- To view, visit https://gerrit.osmocom.org/11827 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee95aa4e5c056645b6cb5667e4a067097d52dfbf Gerrit-Change-Number: 11827 Gerrit-PatchSet: 5 Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 20 Nov 2018 14:48:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/a7d03076/attachment.htm>