Change in osmo-sgsn[master]: Fix IMSI padding in imsi-acl

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Nov 20 09:27:25 UTC 2018


Max has uploaded this change for review. ( https://gerrit.osmocom.org/11838


Change subject: Fix IMSI padding in imsi-acl
......................................................................

Fix IMSI padding in imsi-acl

In I73fd54ad3a4ab8be5aff0fee5c722597ad766e9d incorrect fix was added
which only initialize first element of array. Fix this by using explicit
index to initialize entire array.

Change-Id: I26e4aa44f159d1b5b91dda4a586fd4e809711245
---
M src/gprs/sgsn_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/38/11838/1

diff --git a/src/gprs/sgsn_vty.c b/src/gprs/sgsn_vty.c
index 601b3c5..f570b83 100644
--- a/src/gprs/sgsn_vty.c
+++ b/src/gprs/sgsn_vty.c
@@ -634,7 +634,7 @@
 	"Remove IMSI from ACL\n"
 	"IMSI of subscriber\n")
 {
-	char imsi_sanitized[GSM23003_IMSI_MAX_DIGITS + 1] = { '0' };
+	char imsi_sanitized[GSM23003_IMSI_MAX_DIGITS + 1] = { [0 ... GSM23003_IMSI_MAX_DIGITS] = '0' };
 	const char *op = argv[0];
 	const char *imsi = imsi_sanitized;
 	size_t len = strnlen(argv[1], GSM23003_IMSI_MAX_DIGITS + 1);

-- 
To view, visit https://gerrit.osmocom.org/11838
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26e4aa44f159d1b5b91dda4a586fd4e809711245
Gerrit-Change-Number: 11838
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/c3b1822b/attachment.htm>


More information about the gerrit-log mailing list