Change in osmo-gsm-manuals[master]: *filter.conf/*.sty: use symlinks to build, common

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Nov 20 01:52:45 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11798 )

Change subject: *filter.conf/*.sty: use symlinks to build, common
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

https://gerrit.osmocom.org/#/c/11798/1/build/Makefile.asciidoc.inc
File build/Makefile.asciidoc.inc:

https://gerrit.osmocom.org/#/c/11798/1/build/Makefile.asciidoc.inc@56
PS1, Line 56: 		build common
I can't seem to find the definitions of the 'build' and 'common' targets ... ?


https://gerrit.osmocom.org/#/c/11798/1/build/Makefile.common.inc
File build/Makefile.common.inc:

https://gerrit.osmocom.org/#/c/11798/1/build/Makefile.common.inc@13
PS1, Line 13: 	ln -s $(OSMO_GSM_MANUALS_DIR)/$@ $@
ah here. ok, removing code dup, but in this case with only two symlinks maybe writing it out would be more readable. I mean, I didn't easily find the target definitions, was expecting a 'build:' somewhere... (but this is not important)


https://gerrit.osmocom.org/#/c/11798/1/build/custom-dblatex.sty
File build/custom-dblatex.sty:

https://gerrit.osmocom.org/#/c/11798/1/build/custom-dblatex.sty@3
PS1, Line 3: %% The "common" folder is symlinked to ./common when building.
heh, sounds like

  ln -s ./common common

I have never tried that, will this break my file system by infinite loop?



-- 
To view, visit https://gerrit.osmocom.org/11798
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cfd1a9ef482d382f10cdf060e8e2cba81852864
Gerrit-Change-Number: 11798
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Nov 2018 01:52:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/a730d71f/attachment.htm>


More information about the gerrit-log mailing list