This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11789 ) Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11789/1/src/gsm/gsm_utils.c File src/gsm/gsm_utils.c: https://gerrit.osmocom.org/#/c/11789/1/src/gsm/gsm_utils.c@751 PS1, Line 751: /*! Resolve GSM band from ARFCN, aborts process on invalid ARFCN I know it comes from previous code, but in doxygen comments, the first summary line must be terminated with a '.' (otherwise the following sentence bleeds into the summary, since doxygen doesn't care about line feeds) (OTOH I'm not sure why we even bother with doxygen, OTOOH since doxygen is currently used let's use it correctly) https://gerrit.osmocom.org/#/c/11789/1/utils/osmo-arfcn.c File utils/osmo-arfcn.c: https://gerrit.osmocom.org/#/c/11789/1/utils/osmo-arfcn.c@80 PS1, Line 80: fprintf(stderr, "ARFCN contains no valid band\n"); no return -EINVAL here? -- To view, visit https://gerrit.osmocom.org/11789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I780d452dcebce385469e32ef2fd844df6033393a Gerrit-Change-Number: 11789 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: Max <msuraev at sysmocom.de> Gerrit-Comment-Date: Tue, 20 Nov 2018 00:30:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181120/fb8a529a/attachment.htm>