This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11833 ) Change subject: send NS_POUT_UNBLOCK_ACK before signalling S_NS_UNBLOCK ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11833/1/src/gb/gprs_ns.c File src/gb/gprs_ns.c: https://gerrit.osmocom.org/#/c/11833/1/src/gb/gprs_ns.c@1417 PS1, Line 1417: if (rc < 0) Worth explaining here in a comment why are we breaking (because we don't want to send messages if we didn't notify the peer correctly). Maybe also a log, not sure if callee already logs something. -- To view, visit https://gerrit.osmocom.org/11833 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3af54a14bb6bcfa167c9a9d9f67835e7f5b9f1bb Gerrit-Change-Number: 11833 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 19 Nov 2018 17:01:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/f4c0a768/attachment.htm>