Change in libosmocore[master]: gsm_44_318.h: remove #if 0 from struct gan_cch_desc_ie

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 19 14:38:46 UTC 2018


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11788 )

Change subject: gsm_44_318.h: remove #if 0 from struct gan_cch_desc_ie
......................................................................

gsm_44_318.h: remove #if 0 from struct gan_cch_desc_ie

These are actually parts of the struct in big endian order, which will soon be
done automatically by struct_endianess.py.

Change-Id: I9bc694f10fa9cef0bb7fc791bb40e7602459b16b
---
M include/osmocom/gsm/protocol/gsm_44_318.h
1 file changed, 0 insertions(+), 17 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/protocol/gsm_44_318.h b/include/osmocom/gsm/protocol/gsm_44_318.h
index 76e8396..6ac02cf 100644
--- a/include/osmocom/gsm/protocol/gsm_44_318.h
+++ b/include/osmocom/gsm/protocol/gsm_44_318.h
@@ -170,15 +170,6 @@
 		dtm:1,
 		att:1,
 		mscr:1;
-#if 0
-	uint8_t mscr:1,
-		att:1,
-		dtm:1,
-		gprs:1,
-		nmo:2,
-		ecmc:1,
-		spare:1;
-#endif
 	uint8_t t3212;
 	uint8_t rac;
 	uint8_t sgsnr:1,
@@ -187,13 +178,5 @@
 		pfcfm:1,
 		tgecs:2,
 		spare2:2;
-#if 0
-	uint8_t spare2:2,
-		tgecs:2,
-		pfcfm:1,
-		re:1,
-		ecmp:1,
-		sgsnr:1;
-#endif
 	uint8_t access_class[2];
 } __attribute__((packed));

-- 
To view, visit https://gerrit.osmocom.org/11788
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bc694f10fa9cef0bb7fc791bb40e7602459b16b
Gerrit-Change-Number: 11788
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181119/10dbe98e/attachment.htm>


More information about the gerrit-log mailing list