This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11792 ) Change subject: libmsc: Don't send SMS STATUS REPORT locally if the ESME accepted it. ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11792/3/src/libmsc/gsm_04_11.c File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/#/c/11792/3/src/libmsc/gsm_04_11.c@690 PS3, Line 690: > Given that this is not part of this patch, […] Is this line modified by your patch? If it is, then submit a new version of the patch without this line formatting change, since it's non-related. If the line is not changed by your patch, then the issue is already there and you can 2 things: 1- Leave it as it is, no problem 2- Submit a separate cosmetic patch to fix it. -- To view, visit https://gerrit.osmocom.org/11792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3529b89535800eaa1127721d613fa7bbcb8b23be Gerrit-Change-Number: 11792 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 16 Nov 2018 14:34:01 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181116/50cfcd1f/attachment.htm>