Change in osmo-ttcn3-hacks[master]: BSC_ConnectionHandler: make VTY interface available

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Nov 13 15:06:17 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11701 )

Change subject: BSC_ConnectionHandler: make VTY interface available
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11701/3/msc/BSC_ConnectionHandler.ttcn
File msc/BSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/11701/3/msc/BSC_ConnectionHandler.ttcn@143
PS3, Line 143: if (not g_vty_initialized) {
the f_init_handler() function should always be called only once per testcase, no need for this g_vty_initialized here.  The remainig other code also doesn't support calling this function multiple times during one testcase.



-- 
To view, visit https://gerrit.osmocom.org/11701
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I684f0a3a435924d81bc5a793cb7b43a3ab9ef842
Gerrit-Change-Number: 11701
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Nov 2018 15:06:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181113/fdef0355/attachment.htm>


More information about the gerrit-log mailing list