This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11606 ) Change subject: gsm0408_rcvmsg: Release lchan if L3 fails to complete ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11606/2/src/osmo-bsc/gsm_04_08_rr.c File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/#/c/11606/2/src/osmo-bsc/gsm_04_08_rr.c@957 PS2, Line 957: /* conn shall release lchan on teardown, also if this Layer 3 Complete is rejected. */ now this comment is not in line with the above. I would have expected the failure to be handled in bsc_compl_l3(), or rather in the subscriber conn FSM. Still need to take a look whether something is missing there. When I look in bsc_compl_l3(), in the end it returns a bool as rc, which is nonsense... so I guess this needs more attention. I'll also take a look later -- To view, visit https://gerrit.osmocom.org/11606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1743f9d5cd0fdbc0fb9afe7bcc0271c897915210 Gerrit-Change-Number: 11606 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Tue, 13 Nov 2018 11:56:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181113/b034d6a7/attachment.htm>