This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11716 ) Change subject: Allow GSM340_PLAN_UNKNOWN on MNCC originated leg. ...................................................................... Patch Set 2: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c@400 PS2, Line 400: switch(mncc->called.plan) { I think we usually use a space between keyword (not functions) and (): switch () I probably did it wrong to in my example in previous patch version, it's one of my usual typos ;) https://gerrit.osmocom.org/#/c/11716/2/src/mncc.c@406 PS2, Line 406: "leg(%u) has unsupported(%d) dial plan.\n", We usually indent next lines to content, not to the "(" character, so it looks like a space is missing here and in line below. -- To view, visit https://gerrit.osmocom.org/11716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d71cac5b169e3b19675b9b9626e6993f3acd979 Gerrit-Change-Number: 11716 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 12 Nov 2018 13:36:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/39ec1982/attachment.htm>