Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Nov 12 12:59:34 UTC 2018


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11728 )

Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/11728/1/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/#/c/11728/1/src/gsm/gsm0808.c@894
PS1, Line 894: 	msgb_tlv_put(msg, GSM0808_IE_CAUSE, params->cause & 0x80 ? 2 : 1, (const uint8_t *)&params->cause);
I think we recently added some code to generate this cause with 1-2 bytes. @max?


https://gerrit.osmocom.org/#/c/11728/1/src/gsm/gsm0808.c@897
PS1, Line 897: 	lai_ci.ident = CELL_IDENT_WHOLE_GLOBAL;
should this come from params ptr?



-- 
To view, visit https://gerrit.osmocom.org/11728
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825106858bd89afc9837811b8fed2e8accc82441
Gerrit-Change-Number: 11728
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 12 Nov 2018 12:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181112/f757c70c/attachment.htm>


More information about the gerrit-log mailing list