Change in osmo-bsc[master]: abis_nm: parse_attr_resp_info_unreported: Fix offset calculation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Fri Nov 9 15:50:47 UTC 2018


Pau Espin Pedrol has submitted this change and it was merged. ( https://gerrit.osmocom.org/11683 )

Change subject: abis_nm: parse_attr_resp_info_unreported: Fix offset calculation
......................................................................

abis_nm: parse_attr_resp_info_unreported: Fix offset calculation

See following specs for related information:
* 3GPP TS 52.021 §8.11.3 Get Attribute Response
* 3GPP TS 52.021 §9.4.64 Get Attribute Response Info

Related: OS#3624
Change-Id: Ie61d70bc28427d5d879638516a36f590ce98bdc7
---
M src/osmo-bsc/abis_nm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index d147606..8f5a514 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -495,7 +495,7 @@
 
 	/* the data starts right after the list of unreported attributes + space for length of that list */
 	if (out_len)
-		*out_len = ari_len - (num_unreported + 2);
+		*out_len = ari_len - (num_unreported + 1);
 
 	return ari + num_unreported + 1; /* we have to account for 1st byte with number of unreported attributes */
 }

-- 
To view, visit https://gerrit.osmocom.org/11683
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie61d70bc28427d5d879638516a36f590ce98bdc7
Gerrit-Change-Number: 11683
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181109/4fab762a/attachment.htm>


More information about the gerrit-log mailing list