Change in osmo-bsc[master]: ipaccess-config: Add -G cmdl opt to query OML IP and Unit ID

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11686 )

Change subject: ipaccess-config: Add -G cmdl opt to query OML IP and Unit ID
......................................................................


Patch Set 4: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/11686/4/src/ipaccess/ipaccess-config.c
File src/ipaccess/ipaccess-config.c:

https://gerrit.osmocom.org/#/c/11686/4/src/ipaccess/ipaccess-config.c@306
PS4, Line 306: 	}
that looks familiar. Any chance of re-using the code from osmo-bsc instead?


https://gerrit.osmocom.org/#/c/11686/4/src/ipaccess/ipaccess-config.c@895
PS4, Line 895: 	printf("  -G --get-attr\t\tGet several attributes from BTS\n");
lol "several"



-- 
To view, visit https://gerrit.osmocom.org/11686
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida416a969a3309868d6f4e50f34b34f224c32dd6
Gerrit-Change-Number: 11686
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Max <msuraev at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Nov 2018 17:12:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/1e51f269/attachment.htm>