Change in osmo-bsc[master]: abis_nm: Support parsing nanoBTS format for Get Attributes Info

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 8 17:04:01 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11695 )

Change subject: abis_nm: Support parsing nanoBTS format for Get Attributes Info
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/11695/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11695/1//COMMIT_MSG@10
PS1, Line 10:   attribute list, and it only contains the unsupported attribute ID list.
ah, here it is


https://gerrit.osmocom.org/#/c/11695/1/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/#/c/11695/1/src/osmo-bsc/abis_nm.c@554
PS1, Line 554: 	/* nanoBTS provides Get Attribute Response Info at random position and only the unreported part of it. */
I don't understand "the unreported part". Maybe it's just me.

Should this happen conditionally, only for nanobts? is it already?



-- 
To view, visit https://gerrit.osmocom.org/11695
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I81a613d53bddf432a79fa5cb0bf9d847b4bdee37
Gerrit-Change-Number: 11695
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Nov 2018 17:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/189b0459/attachment.htm>


More information about the gerrit-log mailing list