Change in osmo-bsc[master]: abis_nm: Add support to parse OML IP and Unit Id in Get Attributes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Nov 8 17:00:43 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11694 )

Change subject: abis_nm: Add support to parse OML IP and Unit Id in Get Attributes
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/#/c/11694/1/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/#/c/11694/1/src/osmo-bsc/abis_nm.c@541
PS1, Line 541: 			LOGPFOH(DNM, LOGL_ERROR, foh, "BTS%u Get Attributes Response: PRIM_OML_CFG_LIST unexpected format: %s\n",
"has unexpected..."?


https://gerrit.osmocom.org/#/c/11694/1/src/osmo-bsc/abis_nm.c@542
PS1, Line 542: 			     bts->nr, osmo_hexdump(data, TLVP_LEN(tp, NM_ATT_IPACC_PRIM_OML_CFG_LIST)));
(is the indenting skew or is it just gerrit)


https://gerrit.osmocom.org/#/c/11694/1/src/osmo-bsc/abis_nm.c@550
PS1, Line 550: 		LOGPFOH(DNM, LOGL_ERROR, foh, "BTS%u Get Attributes Response: Unit ID is %s\n", bts->nr, unit_id);
that's not an error



-- 
To view, visit https://gerrit.osmocom.org/11694
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia05e0b8fe3e28aaf2b2253d018f0614e83e23caa
Gerrit-Change-Number: 11694
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 08 Nov 2018 17:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181108/715c0995/attachment.htm>


More information about the gerrit-log mailing list