Change in osmo-ttcn3-hacks[master]: PCU: cleanup test config

[Max]

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11643 )

Change subject: PCU: cleanup test config
......................................................................

PCU: cleanup test config

* remove unused parameters
* add expected results
* use control for default test execution
* only tests which could (in theory) pass are left in control

Previously generic control had some tests which never called
"setverdict(pass)" which means they would always fail. Such tests might
be useful during development but should not be part of test set executed
by default.

Change-Id: I91910e18f108f8ee9a3b76ced16c420fdbdb665a
Related: OS#2890
---
M pcu/PCU_Tests.cfg
M pcu/PCU_Tests.ttcn
A pcu/expected-results.xml
3 files changed, 12 insertions(+), 22 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/pcu/PCU_Tests.cfg b/pcu/PCU_Tests.cfg
index 7e0b9f2..5975290 100644
--- a/pcu/PCU_Tests.cfg
+++ b/pcu/PCU_Tests.cfg
@@ -7,10 +7,6 @@
 ConsoleMask := ERROR | WARNING | TESTCASE | TIMEROP_START | DEBUG_ENCDEC
 
 [MODULE_PARAMETERS]
-#mp_local_ip := "192.168.100.239"
-#mp_local_udp_port := 23000
-#mp_remote_ip := "192.168.100.196"
-#mp_remote_udp_port := 21000
 PCU_Tests.mp_nsconfig := {
 	local_ip := "127.0.0.1",
 	local_udp_port := 23000,
@@ -36,26 +32,18 @@
 }
 
 [TESTPORT_PARAMETERS]
-#*.BSCVTY.CTRL_MODE := "client"
-#*.BSCVTY.CTRL_HOSTNAME := "127.0.0.1"
-#*.BSCVTY.CTRL_PORTNUM := "4242"
-#*.BSCVTY.CTRL_LOGIN_SKIPPED := "yes"
-#*.BSCVTY.CTRL_DETECT_SERVER_DISCONNECTED := "yes"
-#*.BSCVTY.CTRL_READMODE := "buffered"
-#*.BSCVTY.CTRL_CLIENT_CLEANUP_LINEFEED := "yes"
-#*.BSCVTY.PROMPT1 := "OpenBSC> "
-#*.BSCVTY.PROMPT2 := "OpenBSC# "
-#*.BSCVTY.REGEX_PROMPT1 := "^OpenBSC.*$"
-
 *.*.udpReuseAddress := "yes";
 
 [MAIN_CONTROLLER]
 
 [EXECUTE]
+PCU_Tests.control
+# for internal use only: will always fail when called as part of normal routine
 #PCU_Tests.TC_selftest_llc
 #PCU_Tests.TC_selftest_rlcmac
 #PCU_Tests.TC_selftest_bssgp
 #PCU_Tests.TC_nsem
 #PCU_Tests.TC_paging
-PCU_Tests.TC_rach
+#PCU_Tests.TC_rach
 #PCU_Tests.TC_selftest_rr
+#PCU_Tests.TC_dl_tbf
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index a63ca1d..adbc73e 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -630,12 +630,8 @@
 
 
 	control {
-		execute(TC_selftest_bssgp());
 		execute(TC_selftest_ns());
-		execute(TC_selftest_llc());
-		execute(TC_selftest_rr());
-		execute(TC_selftest_rlcmac());
-		execute(TC_nsem());
-		execute(TC_paging());
+		execute(TC_ul_tbf_single_llc_sizes());
+		execute(TC_ul_tbf());
 	}
 };
diff --git a/pcu/expected-results.xml b/pcu/expected-results.xml
new file mode 100644
index 0000000..aec661d
--- /dev/null
+++ b/pcu/expected-results.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0"?>
+<testsuite name='PCU_Tests' tests='3' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'>
+  <testcase classname='PCU_Tests' name='TC_ul_tbf_single_llc_sizes' time='MASKED'/>
+  <testcase classname='PCU_Tests' name='TC_ul_tbf' time='MASKED'/>
+  <testcase classname='PCU_Tests' name='TC_selftest_ns' time='MASKED'/>
+</testsuite>

-- 
To view, visit https://gerrit.osmocom.org/11643
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I91910e18f108f8ee9a3b76ced16c420fdbdb665a
Gerrit-Change-Number: 11643
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181106/d399fef4/attachment.htm>