Change in osmo-bsc[master]: vty: don't show GPRS details if not configured

[Max]

Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/11626 )

Change subject: vty: don't show GPRS details if not configured
......................................................................

vty: don't show GPRS details if not configured

In 'show bts' command only display details of GPRS MO if GPRS is
configured for this BTS.

Change-Id: I082a9fecfa337dff5342b79cca8144b0ceaab15d
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 13 insertions(+), 8 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 410cdac..84752dd 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -447,14 +447,19 @@
 	net_dump_nmstate(vty, &bts->mo.nm_state);
 	vty_out(vty, "  Site Mgr NM State: ");
 	net_dump_nmstate(vty, &bts->site_mgr.mo.nm_state);
-	vty_out(vty, "  GPRS NSE: ");
-	net_dump_nmstate(vty, &bts->gprs.nse.mo.nm_state);
-	vty_out(vty, "  GPRS CELL: ");
-	net_dump_nmstate(vty, &bts->gprs.cell.mo.nm_state);
-	vty_out(vty, "  GPRS NSVC0: ");
-	net_dump_nmstate(vty, &bts->gprs.nsvc[0].mo.nm_state);
-	vty_out(vty, "  GPRS NSVC1: ");
-	net_dump_nmstate(vty, &bts->gprs.nsvc[1].mo.nm_state);
+
+	if (bts->gprs.mode != BTS_GPRS_NONE) {
+		vty_out(vty, "  GPRS NSE: ");
+		net_dump_nmstate(vty, &bts->gprs.nse.mo.nm_state);
+		vty_out(vty, "  GPRS CELL: ");
+		net_dump_nmstate(vty, &bts->gprs.cell.mo.nm_state);
+		vty_out(vty, "  GPRS NSVC0: ");
+		net_dump_nmstate(vty, &bts->gprs.nsvc[0].mo.nm_state);
+		vty_out(vty, "  GPRS NSVC1: ");
+		net_dump_nmstate(vty, &bts->gprs.nsvc[1].mo.nm_state);
+	} else
+		vty_out(vty, "  GPRS: not configured%s", VTY_NEWLINE);
+
 	vty_out(vty, "  Paging: %u pending requests, %u free slots%s",
 		paging_pending_requests_nr(bts),
 		bts->paging.available_slots, VTY_NEWLINE);

-- 
To view, visit https://gerrit.osmocom.org/11626
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I082a9fecfa337dff5342b79cca8144b0ceaab15d
Gerrit-Change-Number: 11626
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181106/df29d383/attachment.htm>