Change in libasn1c[master]: remove a redundant assertion

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Tue Nov 6 13:51:58 UTC 2018


Stefan Sperling has uploaded this change for review. ( https://gerrit.osmocom.org/11625


Change subject: remove a redundant assertion
......................................................................

remove a redundant assertion

Prevent an assert() with an uninitialized variable. The same assertion
is run again once the variable t2m_count has been initialized.

Similar change was made upstream, albeit in a different function,
as part of this commit:
https://github.com/vlm/asn1c/commit/fb6344ef750a4d822ecd613819deba89b181b932

Change-Id: Ib81e76cfb339838f5e8981d175176557f1a8a63f
Related: CID#57935
---
M src/constr_SET.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libasn1c refs/changes/25/11625/1

diff --git a/src/constr_SET.c b/src/constr_SET.c
index 8a124c0..b249869 100644
--- a/src/constr_SET.c
+++ b/src/constr_SET.c
@@ -670,7 +670,6 @@
 	/*
 	 * Finalize order of the components.
 	 */
-	assert(t2m_count == td->elements_count);
 	if(t2m_build_own) {
 		/*
 		 * Sort the underlying members according to their

-- 
To view, visit https://gerrit.osmocom.org/11625
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libasn1c
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib81e76cfb339838f5e8981d175176557f1a8a63f
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181106/27805fa7/attachment.htm>


More information about the gerrit-log mailing list