Change in osmo-ttcn3-hacks[master]: LCLS: explicitly check for *CX adjustment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Nov 5 04:00:02 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11558 )

Change subject: LCLS: explicitly check for *CX adjustment
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11558/2/bsc/MSC_ConnectionHandler.ttcn
File bsc/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/11558/2/bsc/MSC_ConnectionHandler.ttcn@823
PS2, Line 823: 			Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "unexpected number of MGW-CRCX transactions on g_media.mgcp_conn[" & int2str(i) & "]");
cosmetic change mixed with unrelated functional change. When reading a patch this makes me spend time trying to figure out how these things are related...



-- 
To view, visit https://gerrit.osmocom.org/11558
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07b2c56991977b5e80c372a5b8338f348f14c076
Gerrit-Change-Number: 11558
Gerrit-PatchSet: 2
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Nov 2018 04:00:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181105/ef59372f/attachment.htm>


More information about the gerrit-log mailing list