Change in osmo-ttcn3-hacks[master]: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/11562 )

Change subject: bts: f_est_dchan: verify Chan Rqd originated by RACH arrives on RSL
......................................................................


Patch Set 2: Code-Review-1

(5 comments)

https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Emulation.ttcn
File library/RSL_Emulation.ttcn:

https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Emulation.ttcn@192
PS2, Line 192: private function f_cid_by_ra_fn2(OCT1 ra, RSL_IE_FrameNumber fn)
Why are you using RSL_IE_FrameNumber here, but f_cid_by_ra_fn is using GsmFrameNumber?

Is f_cid_by_ra_fn2 meant to replace the older function in other cases?


https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Emulation.ttcn@194
PS2, Line 194: 	var RSL_IE_FrameNumber ct_fn;
unused variable


https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Emulation.ttcn@427
PS2, Line 427: 			var GsmFrameNumber fn;
Unused?


https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Types.ttcn
File library/RSL_Types.ttcn:

https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Types.ttcn@408
PS2, Line 408: 	function f_compute_RSL_IE_FrameNumber(GsmFrameNumber fn) return RSL_IE_FrameNumber {
There's a template that does that....


https://gerrit.osmocom.org/#/c/11562/2/library/RSL_Types.ttcn@462
PS2, Line 462: 	template (value) RSL_IE_FrameNumber ts_RSL_IE_FrameNumber(GsmFrameNumber fn) := {
...right here.
You should be able to use the template in a comparison.



-- 
To view, visit https://gerrit.osmocom.org/11562
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I438fd3ee82d88498d928dbcc89ce9bd80d37ab64
Gerrit-Change-Number: 11562
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Nov 2018 20:17:07 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20181101/73607836/attachment.htm>