Change in libosmocore[master]: GSUP: implement TCAP-like session management

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu May 31 13:29:05 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/7700 )

Change subject: GSUP: implement TCAP-like session management
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/7700/2/include/osmocom/gsm/gsup.h
File include/osmocom/gsm/gsup.h:

https://gerrit.osmocom.org/#/c/7700/2/include/osmocom/gsm/gsup.h@197
PS2, Line 197: 	/*! Unique session identifier and origination flag */
it might make sense to explain that this field (session id) is only valid if session_state != 0



-- 
To view, visit https://gerrit.osmocom.org/7700
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1cee271fed0284a134ffed103c0d4bebbcfde2a8
Gerrit-Change-Number: 7700
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 31 May 2018 13:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180531/29e2da43/attachment.htm>


More information about the gerrit-log mailing list