Change in osmo-pcu[master]: fix time-delta calculations for measurement reports

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Thu May 31 12:14:27 UTC 2018


Hello Pau Espin Pedrol, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/9397

to look at the new patch set (#2).

Change subject: fix time-delta calculations for measurement reports
......................................................................

fix time-delta calculations for measurement reports

The previous implementation unconditionally subtracted nanosecond
values from different time measurements, causing overflow if the
current measurement was taken in less of a fraction of a second
than the past measurement. Use timespecsub() instead, which
accounts for nanoseconds correctly.

Also, fix calculations of KBit/s throughtput. It was not being
calculated correctly, since it was actually accounting for one
KB per 128th-part-of-a-second.

Change-Id: I7d22e7b5902c230efeae66eb20c17026a4037887
Related: OS#3225
---
M src/gprs_rlcmac_meas.cpp
1 file changed, 14 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/97/9397/2
-- 
To view, visit https://gerrit.osmocom.org/9397
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d22e7b5902c230efeae66eb20c17026a4037887
Gerrit-Change-Number: 9397
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180531/6588b576/attachment.htm>


More information about the gerrit-log mailing list