This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9379 ) Change subject: ortp: reset rtp session on SSRC changes ...................................................................... ortp: reset rtp session on SSRC changes When libortp detects a timestamp jump, we resynchronize the session in order to restore proper rtp frame reception. However, we do not resynchronize on an SSRC change. An SSRC change usually indicates the change of an RTP stream source, which is a much more profound event than a timestamp change, so we should even reset the session on SSRC changes. Also, not resynchronizing the session on an SSRC change causes problems when the jitter buffer feature is used. In those cases it takes libortp a long time until it finally detects the timestamp jump and the session resyhcornization happens late. - reset the ession on SSRC changes by calling rtp_session_reset() Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Related OS#3299 --- M src/trau/osmo_ortp.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Pau Espin Pedrol: Looks good to me, but someone else must approve Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c index 18a6123..9062289 100644 --- a/src/trau/osmo_ortp.c +++ b/src/trau/osmo_ortp.c @@ -114,7 +114,8 @@ uint32_t ssrc = rtp_session_get_recv_ssrc(rs); LOGP(DLMIB, LOGL_INFO, - "osmo-ortp(%d): ssrc_changed to 0x%08x\n", port, ssrc); + "osmo-ortp(%d): ssrc_changed to 0x%08x, resetting\n", port, ssrc); + rtp_session_reset(rs); } static void ortp_sig_cb_pt(RtpSession *rs, void *data) -- To view, visit https://gerrit.osmocom.org/9379 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8688a55cd20d0e14493c357db80754851e12f2fb Gerrit-Change-Number: 9379 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: dexter <pmaier at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180530/80198c3c/attachment.htm>