Change in osmo-sip-connector[master]: Add Cause to DISCONNECT and RELEASE Requests

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Mon May 28 12:22:22 UTC 2018


Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/9270 )

Change subject: Add Cause to DISCONNECT and RELEASE Requests
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/9270/1/src/mncc.c
File src/mncc.c:

https://gerrit.osmocom.org/#/c/9270/1/src/mncc.c@113
PS1, Line 113: 		mncc->cause.location = GSM48_CAUSE_LOC_PUN_S_LU;
> please use GSM48_CAUSE_LOC_PUN_S_LU instead of a magic number "2". […]
Done



-- 
To view, visit https://gerrit.osmocom.org/9270
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d3fe3f0c9e8de26dd0c73b10b7e4fc63dff3952
Gerrit-Change-Number: 9270
Gerrit-PatchSet: 2
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Comment-Date: Mon, 28 May 2018 12:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180528/d3b75f9c/attachment.htm>


More information about the gerrit-log mailing list