This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9251 )
Change subject: SGSN: add TC_hlr_location_cancel_request_update
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/9251/4/sgsn/SGSN_Tests.ttcn
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/#/c/9251/4/sgsn/SGSN_Tests.ttcn@1269
PS4, Line 1269: [] BSSGP.receive(tr_BD_L3_MT(*)) {
this only installs a receive handler for downlink layer3 messages. What about user-data or paging or other messages? I think there should be a BSSGP.receive { } clause with either repeat or setverdict(fail), to catch any other BSSGP messages. It's a question of policy. I would typically "repeat" (and hence ignore) any unexpected message, unless we know that no such messages are permitted in this state.
--
To view, visit https://gerrit.osmocom.org/9251
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d3a818eb0a4eb3b0d4bd7bd88874bd2ac6adb11
Gerrit-Change-Number: 9251
Gerrit-PatchSet: 4
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 26 May 2018 21:03:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180526/ac35fde1/attachment.htm>