Change in osmo-ttcn3-hacks[master]: bsc: Don't expect codec list in IPA/SCCPlite case

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9324 )

Change subject: bsc: Don't expect codec list in IPA/SCCPlite case
......................................................................

bsc: Don't expect codec list in IPA/SCCPlite case

In classic non-AoIP-cases, OsmoBSC should simply return the
chosen speech version, but not any codec list in the BSSMAP ASSIGNMENT
COMPLETE message.  Let's adjust the expectations accordingly.

Related: OS#2544
Change-Id: Id8e2a749bce91cfadd316bc2d56d1289412b9026
---
M bsc/BSC_Tests.ttcn
1 file changed, 5 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 95b7625..2534cf6 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1737,11 +1737,13 @@
 	var template PDU_BSSAP exp_compl := f_gen_exp_compl();
 
 	/* puzzle together the ASSIGNMENT REQ for given codec[s] */
-	ass_cmd.pdu.bssmap.assignmentRequest.codecList := g_pars.ass_codec_list;
+	if (mp_bssap_cfg.transport == BSSAP_TRANSPORT_AoIP) {
+		ass_cmd.pdu.bssmap.assignmentRequest.codecList := g_pars.ass_codec_list;
+		exp_compl.pdu.bssmap.assignmentComplete.speechCodec.codecElements[0] :=
+								g_pars.ass_codec_list.codecElements[0];
+	}
 	ass_cmd.pdu.bssmap.assignmentRequest.channelType :=
 				f_BSSMAP_chtype_from_codec(g_pars.ass_codec_list.codecElements[0]);
-	exp_compl.pdu.bssmap.assignmentComplete.speechCodec.codecElements[0] :=
-							g_pars.ass_codec_list.codecElements[0];
 	log("expecting ASS COMPL like this: ", exp_compl);
 
 	f_establish_fully(ass_cmd, exp_compl);

-- 
To view, visit https://gerrit.osmocom.org/9324
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8e2a749bce91cfadd316bc2d56d1289412b9026
Gerrit-Change-Number: 9324
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180525/98767e21/attachment.htm>