Change in osmo-bsc[master]: bsc: Don't reject ASSIGNMENT for Audio in IPA/SCCPlite case

[Harald Welte]

Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9320


Change subject: bsc: Don't reject ASSIGNMENT for Audio in IPA/SCCPlite case
......................................................................

bsc: Don't reject ASSIGNMENT for Audio in IPA/SCCPlite case

Change-Id: If362a0084de452727cd063063dfb645eca2f9beb
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 1 insertion(+), 13 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/20/9320/1

diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 1dfd5b4..d9fe103 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -710,23 +710,11 @@
 			aoip = true;
 		} else {
 			LOGP(DMSC, LOGL_ERROR, "AoIP transport address and CIC missing. "
-			     "Audio will not work.\n");
+			     "Audio would not work; rejecting\n");
 			cause = GSM0808_CAUSE_INFORMATION_ELEMENT_OR_FIELD_MISSING;
 			goto reject;
 		}
 
-		/* FIXME: At the moment osmo-bsc does not support any other
-		 * A-Interface other than AoIP. So we must reject all
-		 * assignment requests that are not AoIP compliant. However,
-		 * might support other A-Interface dialects lateron again,
-		 * thats why we preserve the logic around the AoIP detection
-		 * here. */
-		if (!aoip) {
-			LOGP(DMSC, LOGL_ERROR, "Requested A-Interface type is not supported! (AoIP only!)\n");
-			cause = GSM0808_CAUSE_REQ_A_IF_TYPE_NOT_SUPP;
-			goto reject;
-		}
-
 		/* Decode speech codec list (AoIP) */
 		conn->codec_list_present = false;
 		if (aoip) {

-- 
To view, visit https://gerrit.osmocom.org/9320
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If362a0084de452727cd063063dfb645eca2f9beb
Gerrit-Change-Number: 9320
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180525/de3c4538/attachment.htm>