This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9302 ) Change subject: read monotonic clock with clock_gettime() instead of gettimeofday() ...................................................................... Patch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/9302/1/src/gprs_rlcmac_meas.cpp File src/gprs_rlcmac_meas.cpp: https://gerrit.osmocom.org/#/c/9302/1/src/gprs_rlcmac_meas.cpp@82 PS1, Line 82: + ((now_tv.tv_nsec/1000 - rssi_tv->tv_nsec/1000) << 7) / 1000000; Probably more exact to divide /1000 after the substraction? https://gerrit.osmocom.org/#/c/9302/1/src/gprs_rlcmac_meas.cpp@134 PS1, Line 134: + ((now_tv.tv_nsec/1000 - loss_tv->tv_nsec/1000) << 7) / 1000000; same https://gerrit.osmocom.org/#/c/9302/1/src/gprs_rlcmac_meas.cpp@178 PS1, Line 178: + ((now_tv.tv_nsec/1000 - bw_tv->tv_nsec/1000) << 7) / 1000000; same https://gerrit.osmocom.org/#/c/9302/1/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/#/c/9302/1/src/tbf.cpp@185 PS1, Line 185: memset(&rssi_tv, 0, sizeof(rssi_tv)); Use timespecclear from include/osmocom/core/timer_compat.h https://gerrit.osmocom.org/#/c/9302/1/src/tbf.cpp@1027 PS1, Line 1027: memset(&dl_bw_tv, 0, sizeof(dl_bw_tv)); Same here -- To view, visit https://gerrit.osmocom.org/9302 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I775d85d0d3ac740330879e588bdab6fce7f0b46c Gerrit-Change-Number: 9302 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 25 May 2018 13:34:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180525/39445340/attachment.htm>