This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Stefan Sperling gerrit-no-reply at lists.osmocom.orgStefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/9301 ) Change subject: fix a one-byte stack buffer overrun in osmo-pcu ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9301/1/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/#/c/9301/1/src/pcu_l1_if.cpp@220 PS1, Line 220: uint8_t data[23+3+1]; /* prefix PLEN */ > It would be nice to have some defines instead of using all this raw values. […] Indeed, this code could use a lot of macros. I want to just fix the crash for now. Converting magic numbers to macros in osmo-pcu can be done in a separate step and it looks like it would be a huge long-term task anyway if done correctly and consistently. -- To view, visit https://gerrit.osmocom.org/9301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08a879d72fcb916f78f175612fd90467d7bdd57c Gerrit-Change-Number: 9301 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de> Gerrit-Comment-Date: Fri, 25 May 2018 13:00:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180525/cc192d47/attachment.htm>