Change in osmo-bsc[master]: assignment: signal assignment failure on chan act nack

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Fri May 25 11:03:01 UTC 2018


Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9281 )

Change subject: assignment: signal assignment failure on chan act nack
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9281/1/src/osmo-bsc/osmo_bsc_api.c
File src/osmo-bsc/osmo_bsc_api.c:

https://gerrit.osmocom.org/#/c/9281/1/src/osmo-bsc/osmo_bsc_api.c@429
PS1, Line 429: 	osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_RR_ASS_FAIL, NULL);
> rather than having a function that consists of only one other function call (and discarding two thir […]
it's a callback in that struct bsc_api.

on another note ... the struct bsc_api existed as an abstraction layer to "plug" old osmo-nitb, plain osmo-bsc or osmo-bsc_nat. It might still make sense with bsc vs. bsc_nat, but since we're ignoring nat in osmo-bsc.git at the moment it feels like the entire bsc_api abstraction is unnecessary, just like the separation of libbsc. But we'll best just keep all that until bsc_nat has "concluded".



-- 
To view, visit https://gerrit.osmocom.org/9281
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib204b4a5272f9b7b60ca5f932cd8a4c857316270
Gerrit-Change-Number: 9281
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 25 May 2018 11:03:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180525/6a3e6d04/attachment.htm>


More information about the gerrit-log mailing list