Change in osmo-mgw[master]: sdp: remove unused alt_codec field from struct mgcp_rtp_end

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu May 24 07:34:58 UTC 2018


dexter has posted comments on this change. ( https://gerrit.osmocom.org/9234 )

Change subject: sdp: remove unused alt_codec field from struct mgcp_rtp_end
......................................................................


Patch Set 1:

(1 comment)

> (1 comment)
 > 
 > patch looks good, just not sure about the semantics. what was the
 > alt-codec intended for and why don't we use it after all?

I have no Idea what this alt_codec was about. When I get the things right then one could negotiate multiple codecs via SDP and then just use them. So basically we deal with multiple alternative codecs which we may switch afterwards and by the standard it may be definitely more than one alternative codec, thats why I do not get why there is only
a single alt codec and not multiple ones.

https://gerrit.osmocom.org/#/c/9234/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9234/1//COMMIT_MSG@11
PS1, Line 11: - remove unused alt_codec field
> oh so there's a scheme behind repeating the same statements
Unfortunately yes. Every commit has a title, an explaination and a bullet point summary. I am not sure if this is right or so. We do not have official rules for this, right?



-- 
To view, visit https://gerrit.osmocom.org/9234
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ff2899e3e61f33eb86f284b50ad8a94a949ed16
Gerrit-Change-Number: 9234
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Thu, 24 May 2018 07:34:58 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180524/841802e9/attachment.htm>


More information about the gerrit-log mailing list