Change in osmo-mgw[master]: protocol: Try whole port range on port allocation

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 23 15:54:46 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9259 )

Change subject: protocol: Try whole port range on port allocation
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/9259/1/src/libosmo-mgcp/mgcp_protocol.c
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/#/c/9259/1/src/libosmo-mgcp/mgcp_protocol.c@367
PS1, Line 367: 	unsigned int trys;
tries


https://gerrit.osmocom.org/#/c/9259/1/src/libosmo-mgcp/mgcp_protocol.c@376
PS1, Line 376: 	trys = range->range_end - range->range_start;
same comment as on the BTS side: The number of tries/attempts is every port, but we increment last_port by two, i.e. in the worst case trying each port twice.  Is this intended?



-- 
To view, visit https://gerrit.osmocom.org/9259
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47f09869eaddd4aea817bb2517362883d65d029
Gerrit-Change-Number: 9259
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 23 May 2018 15:54:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180523/ae272fdf/attachment.htm>


More information about the gerrit-log mailing list