Change in osmo-bts[master]: rtp: make port range configurable, assign correct port numbers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 23 15:53:26 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9261 )

Change subject: rtp: make port range configurable, assign correct port numbers
......................................................................


Patch Set 2:

(4 comments)

the patchset is definitely an improvement over the current code.

just for the record: Another approach would be to simply pre-bind the RTP+RTCP ports for all lchan's at the time a TS/pchan is activated.  This way we avoid possibly time-consuming iterations at every lchan activation time (in case many ports are already used and hence we need to do many attempts).

https://gerrit.osmocom.org/#/c/9261/2/include/osmo-bts/gsm_data_shared.h
File include/osmo-bts/gsm_data_shared.h:

https://gerrit.osmocom.org/#/c/9261/2/include/osmo-bts/gsm_data_shared.h@692
PS2, Line 692: 	uint32_t rtp_port_range_start;
unimportant: uint16_t would have been sufficient / more natural for port numbers.  but nevermind...


https://gerrit.osmocom.org/#/c/9261/2/src/common/rsl.c
File src/common/rsl.c:

https://gerrit.osmocom.org/#/c/9261/2/src/common/rsl.c@1794
PS2, Line 1794: 	unsigned int trys;
tries


https://gerrit.osmocom.org/#/c/9261/2/src/common/rsl.c@1796
PS2, Line 1796: 	trys = bts->rtp_port_range_end - bts->rtp_port_range_start;
total number of attempts/tries is 16k ports (using your default values)...


https://gerrit.osmocom.org/#/c/9261/2/src/common/rsl.c@1804
PS2, Line 1804: 		bts->rtp_port_range_next += 2;
however, the port numbers are incremented by two.  This means we're trying each port twice, or am I missing something?



-- 
To view, visit https://gerrit.osmocom.org/9261
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id75f1dfaf898ed8750d28b1c4840e188f4cfdc87
Gerrit-Change-Number: 9261
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 23 May 2018 15:53:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180523/eb15f782/attachment.htm>


More information about the gerrit-log mailing list