Change in libosmo-abis[master]: ipaccess: ipaccess_rcvmsg: Drop unneeded memcpy

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed May 23 15:40:48 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9262 )

Change subject: ipaccess: ipaccess_rcvmsg: Drop unneeded memcpy
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/9262/1/src/input/ipaccess.c
File src/input/ipaccess.c:

https://gerrit.osmocom.org/#/c/9262/1/src/input/ipaccess.c@197
PS1, Line 197: 			INIT_LLIST_HEAD(&newbfd->list);
if the memcpy is not needed, then the INIT_LLIST_HEAD is also not needed.  That is only needed for the actual "head" of the list, and not for a simple element we're adding to the list (like the bsc_fd).



-- 
To view, visit https://gerrit.osmocom.org/9262
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac74843cbed920a2fdc6ade7aef4d4de905939a
Gerrit-Change-Number: 9262
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Wed, 23 May 2018 15:40:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180523/fa82d0a8/attachment.htm>


More information about the gerrit-log mailing list