Change in osmo-msc[master]: implement periodic Location Update expiry in the VLR

[Neels Hofmeyr]

Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/9211 )

Change subject: implement periodic Location Update expiry in the VLR
......................................................................


Patch Set 6:

(4 comments)

let me apply the cosmetics and merge...

https://gerrit.osmocom.org/#/c/9211/6/include/osmocom/msc/vlr.h
File include/osmocom/msc/vlr.h:

https://gerrit.osmocom.org/#/c/9211/6/include/osmocom/msc/vlr.h@23
PS6, Line 23: #define VLR_SUBSCRIBER_NO_EXPIRATION	0x0
(hex doesn't really apply)


https://gerrit.osmocom.org/#/c/9211/6/src/libvlr/vlr.c
File src/libvlr/vlr.c:

https://gerrit.osmocom.org/#/c/9211/6/src/libvlr/vlr.c@478
PS6, Line 478: 		vsub->expire_lu = VLR_SUBSCRIBER_NO_EXPIRATION;
I still don't like to introduce a backdoor that allows subscribers to never expire by fudging about with the server's clock. But yeah, if no-one else shares that view... I don't expect it to apply in reality, but if it ever does, I'll say "I told you so" ;)


https://gerrit.osmocom.org/#/c/9211/6/src/libvlr/vlr_lu_fsm.c
File src/libvlr/vlr_lu_fsm.c:

https://gerrit.osmocom.org/#/c/9211/6/src/libvlr/vlr_lu_fsm.c@359
PS6, Line 359: 		/* Balanced by vlr_subscr_rx_imsi_detach() or Location Update expiry */
still prefer "by vlr_subscr_expire()", which is accurate for both cases and pinpoints the actual place in the code.


https://gerrit.osmocom.org/#/c/9211/6/tests/msc_vlr/msc_vlr_test_no_authen.c
File tests/msc_vlr/msc_vlr_test_no_authen.c:

https://gerrit.osmocom.org/#/c/9211/6/tests/msc_vlr/msc_vlr_test_no_authen.c@952
PS6, Line 952: 	btw("having received subscriber data does not mean acceptance");
(these few lines are actually not related to the timeout and could be dropped, knowing that they are already checked in the other test)



-- 
To view, visit https://gerrit.osmocom.org/9211
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdee8b12d22acfcfb265ee41e71cfc8d9eb3ba9
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 6
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Wed, 23 May 2018 12:55:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180523/e892d223/attachment.htm>