Change in osmo-ttcn3-hacks[master]: MSC_ConnectionHandler: check channel mode in f_establish_fully

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat May 19 08:10:47 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9231 )

Change subject: MSC_ConnectionHandler: check channel mode in f_establish_fully
......................................................................


Patch Set 2:

A TCH can also be in signaling mode, which your new function doesn't cover. Please at least add a fimxe to the code and mention it in the commitlog. Thanks


-- 
To view, visit https://gerrit.osmocom.org/9231
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9004f299220b01ecea6b2316ba3f913c316947dc
Gerrit-Change-Number: 9231
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <laforge at gnumonks.org>
Gerrit-Comment-Date: Sat, 19 May 2018 08:10:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180519/65d7d6c1/attachment.htm>


More information about the gerrit-log mailing list