Change in osmo-msc[master]: remove redundant unconditional PKG_CHECK_MODULES for libsmpp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri May 18 12:43:21 UTC 2018


Stefan Sperling has submitted this change and it was merged. ( https://gerrit.osmocom.org/9220 )

Change subject: remove redundant unconditional PKG_CHECK_MODULES for libsmpp
......................................................................

remove redundant unconditional PKG_CHECK_MODULES for libsmpp

The configure script should only check for libsmpp with --enable-smpp.

Also, disable the build of smpp_mirror with --disable-smpp.

Change-Id: Ic4a8a5c970c04a6257ee4c8e3977e98c4ddfda13
Fixes: a55dda703fc5e367bd58b5f9f6986d62ffbbdb6c
Related: If7e1af11cdac8587bb4d66fb4eacee4b79945359
Related: OS#3232
---
M configure.ac
M src/utils/Makefile.am
2 files changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/configure.ac b/configure.ac
index deee84b..c02b74d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -48,7 +48,6 @@
 PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 0.9.0)
 PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 0.9.0)
 PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.3.0)
-PKG_CHECK_MODULES(LIBSMPP34, libsmpp34 >= 1.13.0)
 
 AC_ARG_ENABLE(sanitize,
 	[AS_HELP_STRING(
diff --git a/src/utils/Makefile.am b/src/utils/Makefile.am
index fad522d..2d67102 100644
--- a/src/utils/Makefile.am
+++ b/src/utils/Makefile.am
@@ -28,7 +28,6 @@
 noinst_PROGRAMS = \
 	smpp_mirror \
 	$(NULL)
-endif
 
 smpp_mirror_SOURCES = \
 	smpp_mirror.c \
@@ -44,4 +43,4 @@
 	$(LIBOSMOGSM_LIBS) \
 	$(LIBSMPP34_LIBS) \
 	$(NULL)
-
+endif

-- 
To view, visit https://gerrit.osmocom.org/9220
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4a8a5c970c04a6257ee4c8e3977e98c4ddfda13
Gerrit-Change-Number: 9220
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180518/283324dc/attachment.htm>


More information about the gerrit-log mailing list