Change in osmo-msc[master]: remove redundant unconditional PKG_CHECK_MODULES for libsmpp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Stefan Sperling gerrit-no-reply at lists.osmocom.org
Fri May 18 12:11:18 UTC 2018


Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/9220 )

Change subject: remove redundant unconditional PKG_CHECK_MODULES for libsmpp
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/9220/2/tests/smpp/Makefile.am
File tests/smpp/Makefile.am:

https://gerrit.osmocom.org/#/c/9220/2/tests/smpp/Makefile.am@1
PS2, Line 1: if BUILD_SMPP
> we also put Makefile paths in configure. […]
This Makefile.am is already excluded in the parent directory if SMPP support is not built. So this already worked as intended. I'll just drop this part of the patch.



-- 
To view, visit https://gerrit.osmocom.org/9220
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a8a5c970c04a6257ee4c8e3977e98c4ddfda13
Gerrit-Change-Number: 9220
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperling at sysmocom.de>
Gerrit-Comment-Date: Fri, 18 May 2018 12:11:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180518/9c3f6976/attachment.htm>


More information about the gerrit-log mailing list