Change in osmo-pcu[master]: Don't register SIGHUP handler without actually handling SIGHUP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue May 15 13:31:55 UTC 2018


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/9165


Change subject: Don't register SIGHUP handler without actually handling SIGHUP
......................................................................

Don't register SIGHUP handler without actually handling SIGHUP

In libosmocore, we normally register a SIGHUP handler for log file
rotation.

However, the osmo-pcu code so far installed its own signal handler,
which did exactly nothing in the SIGHUP case.

Let's fix this by removing SIGHUP handling here, letting libosmocore
take care about this.

Change-Id: Ifa20d79770bc4d88d40601b008a3a2a79d083c04
Closes: OS#3265
---
M src/pcu_main.cpp
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/65/9165/1

diff --git a/src/pcu_main.cpp b/src/pcu_main.cpp
index 84ade6f..611b2d0 100644
--- a/src/pcu_main.cpp
+++ b/src/pcu_main.cpp
@@ -308,12 +308,12 @@
 		return rc;
 
 	signal(SIGINT, sighandler);
-	signal(SIGHUP, sighandler);
 	signal(SIGTERM, sighandler);
 	signal(SIGPIPE, sighandler);
 	signal(SIGABRT, sighandler);
 	signal(SIGUSR1, sighandler);
 	signal(SIGUSR2, sighandler);
+	osmo_init_ignore_signals();
 
 	/* enable realtime priority for us */
 	if (rt_prio != -1) {

-- 
To view, visit https://gerrit.osmocom.org/9165
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa20d79770bc4d88d40601b008a3a2a79d083c04
Gerrit-Change-Number: 9165
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180515/31cb8929/attachment.htm>


More information about the gerrit-log mailing list